-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat#23 add test to imputation methods and fix bug in AverageImputation
Average imputation throwed RuntimeException beacuse the condition in the isDigit() method was returning false for blank values.Fixed with an or gate.
- Loading branch information
Showing
4 changed files
with
100 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
lib/src/test/java/de/edux/functions/imputation/AverageImputationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package de.edux.functions.imputation; | ||
|
||
import static org.junit.jupiter.api.Assertions.*; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
class AverageImputationTest { | ||
@Test | ||
void performImputationWithCategoricalValuesShouldThrowRuntimeException() { | ||
String[] categorical_features = {"A", "B", "C"}; | ||
assertThrows(RuntimeException.class,() -> new AverageImputation().performImputation(categorical_features)); | ||
} | ||
|
||
@Test | ||
void performImputationWithNumericalValuesTest() { | ||
String[] numerical_features_with_missing_values = {"1", "","2", "3", "", "4"}; | ||
AverageImputation imputter = new AverageImputation(); | ||
String[] numerical_features_with_imputted_values = imputter.performImputation(numerical_features_with_missing_values); | ||
assertAll( | ||
() -> assertEquals("2.5", numerical_features_with_imputted_values[1]), | ||
() -> assertEquals("2.5", numerical_features_with_imputted_values[4]) | ||
); | ||
} | ||
} |
30 changes: 30 additions & 0 deletions
30
lib/src/test/java/de/edux/functions/imputation/ModeImputationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
package de.edux.functions.imputation; | ||
|
||
import static org.junit.jupiter.api.Assertions.*; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
class ModeImputationTest { | ||
|
||
@Test | ||
void performImputationWithNumericalValuesTest() { | ||
String[] numerical_features_with_missing_values = {"1", "","1", "2", "", "3"}; | ||
ModeImputation imputter = new ModeImputation(); | ||
String[] numerical_features_with_imputted_values = imputter.performImputation(numerical_features_with_missing_values); | ||
assertAll( | ||
() -> assertEquals("1", numerical_features_with_imputted_values[1]), | ||
() -> assertEquals("1", numerical_features_with_imputted_values[4]) | ||
); | ||
} | ||
|
||
@Test | ||
void performImputationWithCategoricalValuesTest() { | ||
String[] numerical_features_with_missing_values = {"A", "","A", "B", "", "C"}; | ||
ModeImputation imputter = new ModeImputation(); | ||
String[] numerical_features_with_imputted_values = imputter.performImputation(numerical_features_with_missing_values); | ||
assertAll( | ||
() -> assertEquals("A", numerical_features_with_imputted_values[1]), | ||
() -> assertEquals("A", numerical_features_with_imputted_values[4]) | ||
); | ||
} | ||
} |