Add better cursor support in stack allocators #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnse-hypixel
changed the title
…rest of api tests
johnse-hypixel
commented
Aug 2, 2023
| @@ -841,6 +841,8 @@ ecs_iter_t ecs_page_iter( | |||
| ecs_check(it->next != NULL, ECS_INVALID_PARAMETER, NULL); | |||
|
|
|||
| ecs_iter_t result = *it; | |||
| result.priv.cache.stack_cursor = NULL; /* Don't copy allocator cursor */ | |||
There was a problem hiding this comment.
Yes. These were the places where I ran into issues with storing pointers. Glad you had the context to know what was expected of the wrapper iterator!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the stack allocator that can cause memory corruption in scenarios where multiple (nested) iterators are iterated.
=== Original message ===
This PR is to fix some tests that have errors hidden by a large bug. These test cases were not properly finishing iteration, nor calling
ecs_iter_fini(). Furthermore, there are cases of overlapping lifetimes of objects allocated on the stack allocator.The test failures in subsequent CI runs shows the errors found be adding consistency checks to the stack allocator. Then as the new tracking of freed data improved, and fixes in some test cases, the CI errors were eliminated over time.
The existing test cases exercised the various lifetime issues that the new tracking is designed to support. Behavior of the allocator is:
The first commit intentionally has the fixes commented out and additional checks to confirm that the iterator is finished. This first commit will therefore fail CI tests a total of 7 failures.The second commit will show these are fixed.