-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up the BAZEL build to work with the new code, and on Windows. #566
Open
mason-bially
wants to merge
2
commits into
SanderMertens:master
Choose a base branch
from
mason-bially:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderMertens
force-pushed
the
master
branch
from
November 30, 2021 12:25
e5f5b80
to
bbe0c47
Compare
@SanderMertens I'm not sure why the CI is failing, appears to be a bake issue? I don't think I'm effecting it. This should conform closer to what you want the bazel build to look like. |
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
December 13, 2021 20:37
8506832
to
ef52875
Compare
SanderMertens
force-pushed
the
master
branch
from
December 29, 2021 05:17
bdff120
to
8f49fbe
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
January 22, 2022 07:05
a540dcc
to
95a0110
Compare
SanderMertens
force-pushed
the
master
branch
from
February 18, 2022 21:14
e499aa8
to
a2efbef
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
March 7, 2022 09:48
6485712
to
0326782
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
May 31, 2022 18:00
07e1c0f
to
5b6eef9
Compare
SanderMertens
force-pushed
the
master
branch
5 times, most recently
from
August 22, 2022 08:19
3a11369
to
e75f6f0
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
August 29, 2023 00:35
0b0631f
to
c4b01f9
Compare
SanderMertens
force-pushed
the
master
branch
from
September 19, 2023 02:09
60a3a11
to
a016e60
Compare
SanderMertens
force-pushed
the
master
branch
from
November 14, 2023 19:08
d99efe2
to
da0221e
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
December 13, 2023 23:59
438bde4
to
220852f
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
February 20, 2024 08:24
3b99938
to
ac6cdca
Compare
SanderMertens
force-pushed
the
master
branch
from
February 25, 2024 04:24
7874ea5
to
f479787
Compare
SanderMertens
force-pushed
the
master
branch
8 times, most recently
from
March 13, 2024 18:12
ace232e
to
b968586
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
April 23, 2024 19:54
301243a
to
4a5784f
Compare
SanderMertens
force-pushed
the
master
branch
from
September 4, 2024 20:36
34dc148
to
c9b99e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the bazel build files to support version 3. I can fix up the example once it's officially released.
So some issues with this build.
I can't put the BUILD file in just the root. This breaks Windows/MSVC due to how it likes to resolve
#include
dependencies (because there is aflecs.h
in the root folder). I also can't put an alias there to enable@flecs
resolving correctly because for whatever reason building//src:flecs
from the root folder also breaks it. Something is wrong in bazel's sandboxing in windows for this specific situation (code at the root).Some tests are not passing on windows. Notably these won't even build because MSVC does not support C99.