Skip no-isset/no-empty check on possibly undefined variable (rectorph…

…p#32)

* Skip no-isset/no-empty check on possibly undefined variable

* fix

src/Guard/EmptyIssetGuard.php

@@ -30,7 +30,7 @@ public function isLegal(Expr $expr, Scope $scope): bool
             return true;
         }
 
-        $varType = $scope->getType($expr);
+        $varType = $scope->getNativeType($expr);
         $varType = TypeCombinator::removeNull($varType);
         return $varType->getObjectClassNames() === [];
     }

tests/Rules/NoEmptyOnObjectRule/Fixture/SkipPhpDocType.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoEmptyOnObjectRule\Fixture;
+
+/** @var SkipPhpDocType|null $x */
+if (!empty($x)) {
+    return $x;
+}
+
+class SkipPhpDocType {}

tests/Rules/NoEmptyOnObjectRule/NoEmptyOnObjectRuleTest.php

@@ -28,6 +28,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipEmptyOnArray.php', []];
         yield [__DIR__ . '/Fixture/SkipEmptyOnArrayNestedOnObject.php', []];
         yield [__DIR__ . '/Fixture/SkipPossibleUndefinedVariable.php', []];
+        yield [__DIR__ . '/Fixture/SkipPhpDocType.php', []];
     }
 
     /**

tests/Rules/NoIssetOnObjectRule/Fixture/SkipPhpDocType.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoIssetOnObjectRule\Fixture;
+
+/** @var SkipPhpDocType|null $x */
+if (isset($x)) {
+    return $x;
+}
+
+class SkipPhpDocType {}

tests/Rules/NoIssetOnObjectRule/NoIssetOnObjectRuleTest.php

@@ -29,6 +29,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipIssetOnArrayNestedOnObject.php', []];
         yield [__DIR__ . '/Fixture/SkipPossibleUndefinedVariable.php', []];
         yield [__DIR__ . '/Fixture/SkipIssetOnPropertyFetch.php', []];
+        yield [__DIR__ . '/Fixture/SkipPhpDocType.php', []];
     }
 
     /**