Update dhclient to non-blocking mode #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if script: | ||
| sh.dhclient("-nw", "-sf", script, iface, _bg=True) | ||
| else: | ||
| sh.dhclient("-nw", iface, _bg=True) |
There was a problem hiding this comment.
should we have a timeout here?
There was a problem hiding this comment.
-nw cause dhclient become a daemon process (nowait). timeout is not required.
There was a problem hiding this comment.
Daemon should not run with sh, use a service script?
There was a problem hiding this comment.
no service for dhclient, did you mean to create a script for dhclient instead of using sh?
There was a problem hiding this comment.
yeah, unless dhclient will do technique like fork, fork change its parent pid to 1.
There was a problem hiding this comment.
I don't want dhclient to be separated from bundle; killed after bundle be killed is allowed.
imZack
added a commit
that referenced
this pull request
Feb 25, 2016
Update dhclient to non-blocking mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.