Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support status and wan #39

Merged
merged 5 commits into from
Feb 6, 2017
Merged

feat: Support status and wan #39

merged 5 commits into from
Feb 6, 2017

Conversation

lwindg
Copy link
Contributor

@lwindg lwindg commented Jan 15, 2017

No description provided.

@lwindg lwindg requested review from taotao and imZack January 15, 2017 10:20
description: Connection status of the interface, true for connected.
wan:
type: boolean
description: Indicate the interface worked as WAN or not (LAN).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the main purpose of attribute wan?
Bundle already has been defined all wan interfaces in json file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A WiFi interface may be in client mode or AP mode. The interface cannot be WAN if in AP mode.

Copy link
Contributor

@imZack imZack Jan 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add another endpoints to let other bundles able to modify route priority/add/remove. In this case, wifi bundle should remove the interface which is in ap mode from routing list. Otherwise, route bundle restart will loose these information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Route bundle depends on all network interface bundles, so it "will" loose all interfaces' information if it restart. The network manager we are thinking about is still under thinking...
We could discuss tomorrow for better method.

@imZack imZack merged commit 54989ac into Sanji-IO:develop Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants