V2 apis bug fix #235
Merged
V2 apis bug fix #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashashkumar
commented
Aug 23, 2024
•
yashashkumar
commented
- Dataset read and dataset export api change to read connectors data from both connector_instance table and dataset_source_config table
- Added batch id in dataset import api request schema
- Expecting connector_config to be one of string or an object in readyToPublish schema
…gs as object and string
…change in dataset transition api
HarishGangula
requested changes
Sep 3, 2024
| ...connector, | ||
| connector_config: JSON.parse(cipherService.decrypt(connector.connector_config)) | ||
| })); | ||
| dataset.connectors_config = dataset?.connectors_config.map((connector: any) => { |
There was a problem hiding this comment.
Move this to separate method this block of code
HarishGangula
approved these changes
Sep 3, 2024
ravismula
added a commit
that referenced
this pull request
Sep 5, 2024
Added api_version to datasets draft table
ravismula
pushed a commit
that referenced
this pull request
Sep 5, 2024
ravismula
added a commit
that referenced
this pull request
Sep 5, 2024
Added Log4J and fixed the Bugs of web console integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.