Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix player destroy function to not affect the DOM #23

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix player destroy function to not affect the DOM #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
{
"$schema": "https://unpkg.com/@changesets/config@2.3.0/schema.json",
"changelog": ["@changesets/changelog-github", { "repo": "rrweb-io/rrweb" }],
"changelog": [
"@changesets/changelog-github",
{
"repo": "rrweb-io/rrweb"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a future PR i'll try to fix this

}
],
"commit": false,
"fixed": [
[
Expand All @@ -16,7 +21,7 @@
],
"linked": [],
"access": "public",
"baseBranch": "master",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
}
8 changes: 8 additions & 0 deletions packages/rrdom-nodejs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# rrdom-nodejs

## 2.0.11

### Patch Changes

- Updated dependencies []:
- @saola.ai/rrweb-snapshot@2.0.11
- @saola.ai/rrdom@2.0.11

## 2.0.10

### Patch Changes
Expand Down
6 changes: 3 additions & 3 deletions packages/rrdom-nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@saola.ai/rrdom-nodejs",
"version": "2.0.10",
"version": "2.0.11",
"scripts": {
"dev": "vite build --watch",
"build": "tsc -noEmit && vite build",
Expand Down Expand Up @@ -55,8 +55,8 @@
"cssom": "^0.5.0",
"cssstyle": "^2.3.0",
"nwsapi": "^2.2.0",
"@saola.ai/rrdom": "^2.0.10",
"@saola.ai/rrweb-snapshot": "^2.0.10"
"@saola.ai/rrdom": "^2.0.11",
"@saola.ai/rrweb-snapshot": "^2.0.11"
},
"browserslist": [
"supports es6-class"
Expand Down
7 changes: 7 additions & 0 deletions packages/rrdom/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# rrdom

## 2.0.11

### Patch Changes

- Updated dependencies []:
- @saola.ai/rrweb-snapshot@2.0.11

## 2.0.10

### Patch Changes
Expand Down
6 changes: 3 additions & 3 deletions packages/rrdom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@saola.ai/rrdom",
"version": "2.0.10",
"version": "2.0.11",
"homepage": "https://github.com/rrweb-io/rrweb/tree/main/packages/rrdom#readme",
"license": "MIT",
"type": "module",
Expand Down Expand Up @@ -41,7 +41,7 @@
"url": "https://github.com/rrweb-io/rrweb/issues"
},
"devDependencies": {
"@saola.ai/rrweb-types": "^2.0.10",
"@saola.ai/rrweb-types": "^2.0.11",
"@types/puppeteer": "^5.4.4",
"@typescript-eslint/eslint-plugin": "^5.23.0",
"@typescript-eslint/parser": "^5.23.0",
Expand All @@ -52,6 +52,6 @@
"vite-plugin-dts": "^3.8.1"
},
"dependencies": {
"@saola.ai/rrweb-snapshot": "^2.0.10"
"@saola.ai/rrweb-snapshot": "^2.0.11"
}
}
7 changes: 7 additions & 0 deletions packages/rrvideo/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# rrvideo

## 2.0.11

### Patch Changes

- Updated dependencies []:
- @saola.ai/rrweb-player@2.0.11

## 2.0.10

### Patch Changes
Expand Down
6 changes: 3 additions & 3 deletions packages/rrvideo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@saola.ai/rrvideo",
"version": "2.0.10",
"version": "2.0.11",
"description": "transform rrweb session into video",
"main": "build/index.js",
"bin": {
Expand All @@ -27,13 +27,13 @@
"@types/node": "^18.15.11",
"jest": "^27.5.1",
"ts-jest": "^27.1.3",
"@saola.ai/rrweb-types": "^2.0.10"
"@saola.ai/rrweb-types": "^2.0.11"
},
"dependencies": {
"@open-tech-world/cli-progress-bar": "^2.0.2",
"fs-extra": "^11.1.1",
"minimist": "^1.2.5",
"playwright": "^1.32.1",
"@saola.ai/rrweb-player": "^2.0.10"
"@saola.ai/rrweb-player": "^2.0.11"
}
}
2 changes: 2 additions & 0 deletions packages/rrweb-player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# rrweb-player

## 2.0.11

## 2.0.10

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/rrweb-player/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "@saola.ai/rrweb-player",
"version": "2.0.10",
"version": "2.0.11",
"devDependencies": {
"@saola.ai/rrweb-types": "^2.0.10",
"@saola.ai/rrweb-types": "^2.0.11",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/package": "^2.0.0",
Expand Down
2 changes: 2 additions & 0 deletions packages/rrweb-snapshot/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# rrweb-snapshot

## 2.0.11

## 2.0.10

## 2.0.9
Expand Down
2 changes: 1 addition & 1 deletion packages/rrweb-snapshot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@saola.ai/rrweb-snapshot",
"version": "2.0.10",
"version": "2.0.11",
"description": "rrweb's component to take a snapshot of DOM, aka DOM serializer",
"scripts": {
"prepare": "npm run prepack",
Expand Down
11 changes: 11 additions & 0 deletions packages/rrweb/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# rrweb

## 2.0.11

### Patch Changes

- Fix player destroy function to not affect the DOM

- Updated dependencies []:
- @saola.ai/rrweb-snapshot@2.0.11
- @saola.ai/rrdom@2.0.11
- @saola.ai/rrweb-types@2.0.11

## 2.0.10

### Patch Changes
Expand Down
8 changes: 4 additions & 4 deletions packages/rrweb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@saola.ai/rrweb",
"version": "2.0.10",
"version": "2.0.11",
"description": "record and replay the web",
"scripts": {
"prepare": "npm run prepack",
Expand Down Expand Up @@ -83,12 +83,12 @@
"vite-plugin-dts": "^3.8.1"
},
"dependencies": {
"@saola.ai/rrweb-types": "^2.0.10",
"@saola.ai/rrweb-types": "^2.0.11",
"@types/css-font-loading-module": "0.0.7",
"@xstate/fsm": "^1.4.0",
"base64-arraybuffer": "^1.0.1",
"mitt": "^3.0.0",
"@saola.ai/rrdom": "^2.0.10",
"@saola.ai/rrweb-snapshot": "^2.0.10"
"@saola.ai/rrdom": "^2.0.11",
"@saola.ai/rrweb-snapshot": "^2.0.11"
}
}
2 changes: 1 addition & 1 deletion packages/rrweb/src/replay/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ export class Replayer {
this.mirror.reset();
this.styleMirror.reset();
this.mediaManager.reset();
this.config.root.removeChild(this.wrapper);
// this.config.root.removeChild(this.wrapper); - Leaving the DOM handling to React, causes issues with Vite's hot reloading
this.emitter.emit(ReplayerEvents.Destroy);
}

Expand Down
7 changes: 7 additions & 0 deletions packages/types/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @rrweb/types

## 2.0.11

### Patch Changes

- Updated dependencies []:
- @saola.ai/rrweb-snapshot@2.0.11

## 2.0.10

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@saola.ai/rrweb-types",
"version": "2.0.10",
"version": "2.0.11",
"publishConfig": {
"access": "public"
},
Expand Down Expand Up @@ -52,7 +52,7 @@
"dependencies": {
"@changesets/cli": "^2.27.1",
"@monorepo-utils/workspaces-to-typescript-project-references": "^2.8.2",
"@saola.ai/rrweb-snapshot": "^2.0.10",
"@saola.ai/rrweb-snapshot": "^2.0.11",
"browserslist": "^4.22.1",
"concurrently": "^7.1.0",
"cssom": "https://registry.npmjs.org/rrweb-cssom/-/rrweb-cssom-0.6.0.tgz",
Expand Down
8 changes: 8 additions & 0 deletions packages/web-extension/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# @rrweb/web-extension

## 2.0.11

### Patch Changes

- Updated dependencies []:
- @saola.ai/rrweb@2.0.11
- @saola.ai/rrweb-player@2.0.11

## 2.0.10

### Patch Changes
Expand Down
8 changes: 4 additions & 4 deletions packages/web-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@saola.ai/rrweb-web-extension",
"private": true,
"version": "2.0.10",
"version": "2.0.11",
"description": "The web extension of rrweb which helps to run rrweb on any website out of box",
"author": "rrweb-io",
"license": "MIT",
Expand All @@ -18,7 +18,7 @@
"prepublish": "yarn build"
},
"devDependencies": {
"@saola.ai/rrweb-types": "^2.0.10",
"@saola.ai/rrweb-types": "^2.0.11",
"@types/react-dom": "^18.0.6",
"@types/webextension-polyfill": "^0.9.1",
"@vitejs/plugin-react": "^4.2.1",
Expand All @@ -42,7 +42,7 @@
"react-dom": "^18.2.0",
"react-icons": "^4.4.0",
"react-router-dom": "^6.4.1",
"@saola.ai/rrweb": "^2.0.10",
"@saola.ai/rrweb-player": "^2.0.10"
"@saola.ai/rrweb": "^2.0.11",
"@saola.ai/rrweb-player": "^2.0.11"
}
}