-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Godot project #1
Merged
Turtyo
merged 14 commits into
Saplings-Projects:main
from
cheesefrycook:cheese_BaseProject
Dec 6, 2023
Merged
Initial Godot project #1
Turtyo
merged 14 commits into
Saplings-Projects:main
from
cheesefrycook:cheese_BaseProject
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turtyo
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the initial setup of the project ! There was a lot of code to review so I might have missed interactions.
I will PR an action later to go with the GUT tests that you wrote.
This was referenced Dec 1, 2023
Turtyo
previously approved these changes
Dec 1, 2023
Turtyo
reviewed
Dec 2, 2023
Adds new helper find_first_from_array_by_type which finds the first type in an array. Using get_script to get the buff type at runtime
Turtyo
reviewed
Dec 3, 2023
Turtyo
previously approved these changes
Dec 3, 2023
Tomzkk
previously approved these changes
Dec 5, 2023
rename to get_first_child_node_of_type as per suggestion
Turtyo
previously approved these changes
Dec 5, 2023
Turtyo
reviewed
Dec 6, 2023
Turtyo
approved these changes
Dec 6, 2023
Tomzkk
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base project with a basic version of card battler combat.
Features:
I included a few buffs and cards as examples of what the systems are capable of.
Select cards with left click, then click a sapling or Fauna to play the card. When you press End Turn, saplings will attack, your hand is refilled, and you can play again.
Includes the GUT package for unit testing
test_health.gd
contains the tests I've written so far. I plan to add more tests in the future.Coding style is based on the GDScript style guide