Better map event distribution

[Lann-hyl]

Description

Changes Map Event generation based on set probabilities instead of just randomness.
There are also rules to prevent cases such as consecutive shop rooms, and floors where events are fixed (heal rooms before boss room).

Related issue(s)

Issue: #108

List of changes

Room events are generated with the following probabilities:

• Mob: 45%
• Random: 16%
• Shop: 5%
• Heal: 12%
• Dialogue: 22%

The probabilities are set in GLOBAL_VAR.gd, and the implementation is in MapManager.gd

We then apply some generation rules that are inspired by this blog:

• Rule 1: No Heal rooms before half of the map
• Rule 2: No consecutive Heal and Shop rooms
• Rule 3: There must be at least 2 room types among destinations of rooms that have 2 or more Paths going out.
• Rule 4: No Heal rooms two floors before Boss (two before last floor)

Also some fixed rooms:

• Last room is set to Mob (placeholder to be replaced by Boss at some point)
• Rooms before boss are Heal rooms (before last floor)

Tests

Tests are written in test_map.gd, they test that the 4 rules described earlier are applied correctly to the test map.

Additional notes

Code in MapManager.gd that counts and prints the number of rooms for each event to verify if we get the number of rooms we want, with randomness. Set DEBUG_PRINT_EVENT_COUNT in DEBUG_VAR.gd to True.

[Turtyo]

A few things to change, but it's mainly details
The comments explain well what you are doing, that's great

Would it be possible to add a test to check the time it takes to generate a map ? Ran multiple times, to know the distribution of times, maybe 100 times ?

[Tomzkk]

The generation and the rules seem good. I had to take time with some of them (3rd one specifically) but then realized it's probably because they are made for the specific map layout we decided on.

If the distributions look good (which is being discussed in other message from turtyo) then it should be good

[Turtyo]

Seems clear, will just test it before approving

[Turtyo]

What happens if we can't generate the map because of rules ? I don't see a retry of the generation

[Turtyo]

Once we have the map re-generation in case we it gets blocked, I think it'll be good for approval

[Turtyo]

Seems good, will just test that tomorrow, a thing to change regarding code structure I think, the double break with a flag is a bit strange

[Turtyo]

Good job 👍

[Tomzkk]

Looks good. Left one small comment but if you think it's okay to keep it there then we don't have to move it.

If the distributions appear good enough, then I think we are good to go with this.