Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added @Override comments for children classes that implement a function declared in a parent class #13

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Added @Override comments for children classes that implement a function declared in a parent class #13

merged 2 commits into from
Dec 9, 2023

Conversation

Turtyo
Copy link
Collaborator

@Turtyo Turtyo commented Dec 8, 2023

Description

As the title says. This allows to know where a function comes from more easily.

Related issue(s)

This was discussed in #3

List of changes

A more detailed list of the changes.

  • Modified all files that have implement parent function
  • Modified CONTRIBUTING.md

Tests

None. This is just comments.

@Turtyo Turtyo added documentation Improvements or additions to documentation enhancement Ask for changes to an existing feature labels Dec 8, 2023
@Turtyo Turtyo linked an issue Dec 8, 2023 that may be closed by this pull request
Add an @Override comment for classes that extend from a parent class #3
Closed
@EChisholm EChisholm self-assigned this Dec 9, 2023
EChisholm
EChisholm approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@EChisholm EChisholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds perfectly reasonable to me. When I inevitably forget to do this, please yell at me to read CONTRIBUTING.md.

@EChisholm EChisholm removed their assignment Dec 9, 2023
@Miniik
Copy link
Collaborator

Miniik commented Dec 9, 2023

This also allows for better organization, making reading this code a lot easier.

@Turtyo Turtyo merged commit 39dd5ad into Saplings-Projects:main Dec 9, 2023
@Turtyo Turtyo deleted the 3-override branch December 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EChisholm EChisholm EChisholm approved these changes

@Miniik Miniik Miniik approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement Ask for changes to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an @Override comment for classes that extend from a parent class
3 participants
@Turtyo @Miniik @EChisholm