Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class structure for the cards #27

Merged
merged 19 commits into from
Dec 23, 2023
Merged

Class structure for the cards #27

merged 19 commits into from
Dec 23, 2023

Commits on Dec 18, 2023

  1. Added a base template for effects and relevant functions in CardBase

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e3656d9 View commit details
    Browse the repository at this point in the history

  2. Reformated to use a list of targets and moved some functions to other… 

    … files

- The CardBase applies all effects when played
- The application of effect is done given the card data (parser TODO)
- This application will be done to all targets in the list
- This calls the apply_effect which is done to individual targets
    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f02be75 View commit details
    Browse the repository at this point in the history

  3. Update Battler to have correct function signature

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    4310bd8 View commit details
    Browse the repository at this point in the history

  4. Simplified _damage_entity since the new logic of effects is applied t… 

    …o one target at once
    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    933ed1d View commit details
    Browse the repository at this point in the history

  5. Simplified can_play_card

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2669640 View commit details
    Browse the repository at this point in the history

  6. Moved the draw to an effect, changed value from float to int

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0e311fe View commit details
    Browse the repository at this point in the history

  7. Moved the discard random to an effect

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2f6f856 View commit details
    Browse the repository at this point in the history

  8. Made the EffectPoison to have a reference for other Status effects

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5b39fce View commit details
    Browse the repository at this point in the history

  9. Moved the deal damage to an effect

    @Turtyo
    Turtyo committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3512e4d View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Changed effects from Node to Resource

    @Turtyo
    Turtyo committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1256839 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Modified Battler and Enemy to work with the new effect structure

    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e1963a9 View commit details
    Browse the repository at this point in the history

  2. Changed EffectData to prevent an init bug | Added basic targeting fun… 

    …ction
    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c028d34 View commit details
    Browse the repository at this point in the history

  3. Modified EffectDamage

    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6ac8308 View commit details
    Browse the repository at this point in the history

  4. Modified damage and draw resources cards to work with new effect system

    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4e58369 View commit details
    Browse the repository at this point in the history

  5. Modified poison to work with new system

    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    584d43e View commit details
    Browse the repository at this point in the history

  6. Added a card with multiple effects to test the current structure 

    It works btw
    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    221a971 View commit details
    Browse the repository at this point in the history

  7. Tried an effect that was a bit more complex 

    It worked nicely. This card probably won't stay as it is, that would be OP
But it's nice to test that the system is working
    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c6a1bba View commit details
    Browse the repository at this point in the history

  8. Changed parameter name from entity to target for more clarity

    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d00f2ba View commit details
    Browse the repository at this point in the history

  9. Removed unused commented line in tests

    @Turtyo
    Turtyo committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    7caeeff View commit details
    Browse the repository at this point in the history