Issue-75: Event Dialogue System #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to show test script when clicking on an elligible room
Turtyo
reviewed
Apr 5, 2024
There was a problem hiding this comment.
It seems to look nice
Did you write everything in balloon.gd or did you copy from an example ?
It's good to have a separate scene so we can implement scene switching on the map once #87 has been discussed
Tests are failing, for the convention it's normal since no line has been added for events.
For the map maybe we should have a boolean to not load dialogues ? i'm not sure, would need to look at the tests in mapUI again
…ny location in Art folder. Update comments
Turtyo
reviewed
Apr 8, 2024
Turtyo
previously approved these changes
Apr 13, 2024
# Conflicts: # Global/DEBUG_VAR.gd # project.godot
Turtyo
approved these changes
Apr 15, 2024
|
@Tysterman74 should this close #75 ? |
Yeah. Were we gonna have another issue later to include in the book background? If so, we can close this. |
|
Yeah I think that was the idea |
JonaLam
approved these changes
Apr 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creation of Dialog Screen for showing events.
Related issue(s)
Relates to #75
List of changes
A more detailed list of the changes.
Tests
Not added yet.
Additional notes
fauna_dialogue_system.mp4