Release v2.0 #3
Merged
Release v2.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naling enabled. Do this even if the browser provides a non '-' string for streamId since we rely on this to generate the source name.
Disable p2p between endpoints that are not running in the same SDP mode. The source-add/source-remove handlers assume the mids to follow the same pattern on both self and peer but the mids generated in plan-b mode are different from unified plan mode. Fixes jitsi/jitsi-meet#11100.
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* fix(multi-stream) add new m-line when remote adds a second video source in p2p. A new m-line needs to be added in the remote description when a new secondary video source is signaled by the peer. * fix(TPC) Suppress lower layers only for screenshare tracks. With multi-stream support enabled, an extra check for videoType for local track is needed to dtermine if the lower layers need to be suppressed. * fix(TPC) Mark the direction inactive on inactive media connection. If a new secondary video source is added on the jvb connection while p2p is active, make sure the direction is set to inactive on the jvb connection, so that no media is being sent out on the jvb connection. * squash: Address review comments.
* Plumbing for e2e pings. * linter fixes * Re-use existing event instead of introducing a new one.
When source-name signaling is enabled, get correct peermedia info when the peer sends presence in the legacy format. This fixes an issue where Jigasi users cannot be heard by endpoints that have source-name signaling enabled.
When a screenshare track is removed in the legacy mode, presence needs to be sent with the muted state and videoType so the remote gets updated.
…very re-connect. This fixes an issue where the receiver constraints and video type messages are sent on the bridge channel only the first time the ws conn gets re-established.
…1983) * fix(video-quality) Update frame heights in content-modify for p2p. When the user changes the preferred video quality settings from the UI, update the frame height values in content-modify for p2p connection when source-name signaling is enabled. * fix(multi-stream) Send presence for desktop track before signaling when it is the first track to be added to the conference. Also do not suppress renegotiation for desktop track on p2p since the browser doesn't fire negotiation needed event. * squash: fix build * squash: fix linter issues * squash: add comment.
…condary video tracks when a session is re-created (#1987)
Discovered it during investigation of jitsi/jicofo#905
With https://bugs.webkit.org/show_bug.cgi?id=179363 being fixed, we should now be able to switch between devices in call.
…yMedia. (#1991) * feat: Add an option to set bogus resolution constraints for getDisplayMedia.
… sources are added.
…listener parameter (#1984) * provide jitsiTrack as parameter of the listeners on JitsiTrackEvents.TRACK_STREAMING_STATUS_CHANGED * reorder params
With that, it's possible to set AV1 as preferred codec for p2p and try it on Chrome.
… have chromium ver < 96.
…uring it. With just source-name enabled, set the source name of the replaced track before configuring the encodings, this fixes an issues where the sender constraints are not applied on the p2p connection because the source name is undefined.
RN clients throw a function undefined error otherwise.
This reverts commit 7d3f13c. This change was not needed.
They have been deprecated and their valued can no longer be changed from the default after M103. Ref: https://groups.google.com/u/0/g/discuss-webrtc/c/2l7jWgreYpw?pli=1
* fix(deployment-info) Prevent error when setting shard and region * fix
* added docs on how to define tokens * fixed typo Co-authored-by: James Green <james.green@affinity-digtal.com>
In most cases it's not a real issue and it's still part of the logs, throwing an unhandled exception at the global handler just prints an ugly trackeback in the JS console which looks much worse than it really is.
Jicofo by default now strips the simulcast SSRCs and sends only the primary SSRC and RTX to all the receiving endpoints in the call. Therefore remote SDP munging is not required on the clients anymore.
…esn't join muc. * fix(SignalingLayer): Skip checking for last presence if the client doesn't join muc. This fixes the broken wireless screensharing issue on spot clients. * squash: change log message to a warning.
the editor will no longer complain about superfluous await when calling these functions
it removed support for functions being simultaneous async and have done parameter in callback
the editor will no longer complain about superfluous await when calling
Reusing(removing it and adding it again) an SSRC in the remote SDP is leading to the issue where remote video is received but not rendered. That's why we shouldn't remove the receive only SSRCs from the SDP. This way the sender won't send any source-remove and source-add for the same SSRCs.
brajendrak00068
force-pushed
the
release-v2.0
branch
from
99dbbea to
e312018
Compare
* fix(SDP): don't separate fmtp parameter with spaces * adjusted tests accordingly to not expect spaces anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.