Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify environment creation #34

Merged
merged 8 commits into from
Jun 17, 2022
Merged

Unify environment creation #34

merged 8 commits into from
Jun 17, 2022

Conversation

SarthakJariwala
Copy link
Owner

@SarthakJariwala SarthakJariwala commented Jun 17, 2022

create command can now create new environments for the following 3 conditions:

New environment from scratch

$ ezconda create --name env

From environment specifications file (yml file)

$ ezconda create --file env.yml

From environment lock file

$ ezconda create --file env-darwin-x86_64.lock

This PR also deprecates recreate command for removal in v0.8.0

Appropriate doc changes were also made to reflect the new changes.

Closes #32

@SarthakJariwala SarthakJariwala added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 17, 2022
@SarthakJariwala SarthakJariwala added this to the v0.7.0 milestone Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #34 (7c6ce42) into main (0df4681) will increase coverage by 0.28%.
The diff coverage is 85.00%.

❗ Current head 7c6ce42 differs from pull request most recent head 7b97950. Consider uploading reports for the commit 7b97950 to get more accurate results

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   91.03%   91.32%   +0.28%     
==========================================
  Files          16       16              
  Lines         502      507       +5     
==========================================
+ Hits          457      463       +6     
+ Misses         45       44       -1     
Impacted Files Coverage Δ
ezconda/create.py 88.13% <83.33%> (+2.42%) ⬆️
ezconda/recreate.py 91.66% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df4681...7b97950. Read the comment docs.

@SarthakJariwala SarthakJariwala merged commit 5bf27ec into main Jun 17, 2022
@SarthakJariwala SarthakJariwala deleted the unify-env-creation branch June 17, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify environment creation under create command
2 participants