Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sasview database #106

Draft
wants to merge 76 commits into
base: refactor_24
Choose a base branch
from
Draft

Sasview database #106

wants to merge 76 commits into from

Conversation

summerhenson
Copy link

Database backend in progress.

Copy link
Collaborator

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my inline comments, a few general notes:

  • I said this in the meeting, but wanted to reiterate it - good use of atomic commits with specific commit messages
  • Some python formatting would be useful. Running everything through ruff could be worthwhile.
  • Relative imports can be fragile, but mostly when trying to run a python file directly. That isn't easy with Django, so it's not that huge an issue, but wanted to mention it.
  • Another thing we discussed at today's meeting, but wanted to mention again, is user auth and request.user clashes. Many of the checks don't ensure the authenticated user is the data owner.

Overall, a good start to the project. I'll try to make comments every week, or as updates are made.

sasdata/fair_database/data/views.py Outdated Show resolved Hide resolved
sasdata/fair_database/data/tests.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants