Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Spelling fixes in two_power_law model #449

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

llimeht
Copy link
Contributor

@llimeht llimeht commented Apr 5, 2021

Fix typos in variable names in code for two_power_law model.

Marked as WIP as it still needs some the code added so that opening old projects still works.

Closes: #444

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While a spelling correction, it is a spelling correction to two of the model parameters. Thus this should not be merged until the proper parameter translation is added to the "translation" file or it will break things like a saved project which will be using the old name.

@krzywon
Copy link
Collaborator

krzywon commented Jul 6, 2021

Copied from #458:

To keep backward compatibility with old save projects saved with old parameter names you will need to update sasmodels/conversion_table.py. The python file houses a dictionary that maps the previous SasView version to the changes made after that version was released. This can accommodate model name and parameter name change.

General usage, but more information is given in the file documentation:

<old_Sasview_version> : {
<new_model_name> : [
<old_model_name> ,
{
<new_param_name_1> : <old_param_name_1>,
...
<new_param_name_n> : <old_param_name_n>
}
]
}

@wpotrzebowski
Copy link

@wpotrzebowski to ask @llimeht if he wants to continue working on it

@smk78 smk78 changed the title Spelling fixes in two_power_law model WIP: Spelling fixes in two_power_law model Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename coefficent_1 to coefficient_1 in two_power_law
4 participants