Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For checking implementation of #284 corrections we can simulate a lattice of spheres and compare the resulting patterns.
The
dnn
parameter as currently implemented represents lattice spacing. For example, the following shows that the peak positions are aligned when the lattice spacing (a=500) matches dnn in the code.The lineshape broadening appears to be less in the theory than in the simulation for a given distortion factor but I have not investigated different distortion factors and different simulation sizes. It may be that the distortion model (gaussian around the lattice point) is not implemented correctly or does not match what the paracrystal models are using for distortion.
Ignore details at low q due to finite lattice size.
The realspace.py is using an incorrect scaling factor, so ignore offset in y.
The basic simulation of a 2D pattern does not have enough resolution to verify the details of the simulation:
Increasing the lattice size did not help. Increasing the name of samples to s=150000 has not yet completed running since the algorithm is O(n²).