Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put labels on weights plot for sasmodels compare app #561

Merged
merged 3 commits into from
May 23, 2023
Merged

Put labels on weights plot for sasmodels compare app #561

merged 3 commits into from
May 23, 2023

Conversation

pkienzle
Copy link
Contributor

There's also code for plotting probability rather than weight, commented out for now but available for future debugging sessions.

@butlerpd butlerpd requested a review from caitwolf April 11, 2023 13:27
caitwolf
caitwolf reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@caitwolf caitwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculation of dx for plotting probability rather than weight in the comments is the only concern I had. Otherwise, everything else looks good when I test the compare app.

sasmodels/weights.py Outdated Show resolved Hide resolved
@wpotrzebowski
Copy link

Waiting for @pkienzle to look at

@wpotrzebowski
Copy link

Ready to merge?

@wpotrzebowski wpotrzebowski merged commit 460b026 into master May 23, 2023
@wpotrzebowski wpotrzebowski deleted the pr-labels-on-weights-plot branch May 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caitwolf caitwolf caitwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkienzle @wpotrzebowski @caitwolf @butlerpd