602: Fix FCC Paracrystal Lattice Parameter Calculation #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values given by Jonathan Gaudet. Note that more robuts testing would be useful and should be added in the future.
butlerpd
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
I know I made the second set of changes, but I asked @JoGaudet who sent me the changes needed in an email. Given the desire to turn this around quickly I entered these for him. He is also the one to give the first change which @krzywon implemented. Given the nature of these changes I feel it can now be merged so approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #602, the FCC Paracrystal model lattice parameter (d_a) chould be calculated by multiplying the nearest neighbor distance (dnn) by sqrt(2), not dividing by it. This fixes that issue.
Note - this model will need a new unit test since it is failing.