Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGL jitter viewer #96

Merged
merged 10 commits into from
Mar 19, 2019
Merged

WebGL jitter viewer #96

merged 10 commits into from
Mar 19, 2019

Conversation

pkienzle
Copy link
Contributor

Better rendering of jitter viewer, using webgl inside a jupyter notebook.

Not yet a standalone solution that can be put into the docs since it uses a python server to generate the scene. Also, the response time for resetting the plot after each scene change is too slow. However, it does do a better job of rendering the view.

The existing mplot3d viewer is still the default. Other than a color change on the parallelepiped, this should not affect sasview.

See ticket 926.

@pkienzle pkienzle changed the base branch from master to beta_approx February 28, 2019 13:48
@pkienzle pkienzle changed the base branch from beta_approx to py3 March 4, 2019 22:11
@pkienzle
Copy link
Contributor Author

pkienzle commented Mar 4, 2019

Basing this off the py3 branch so that I can resolve the merge conflict early.

@butlerpd butlerpd requested a review from mdoucet March 5, 2019 14:56
@pkienzle
Copy link
Contributor Author

pkienzle commented Mar 5, 2019

I tested that it works with the existing ">Tools >Orientation Viewer" menu option in sasview master.

@pkienzle pkienzle changed the base branch from py3 to beta_approx March 6, 2019 22:11
Copy link
Contributor

@mdoucet mdoucet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using > Tools > Orientation Viewer from the menu in the latest Master build but it didn't show me anything. What's the expected behavior here?

@pkienzle
Copy link
Contributor Author

Orientation viewer menu in sasview should pop up a 3-D parallelpiped which you can rotate with sliders. If it does not, then perhaps it is because you have an old version of matplotlib. Here is the stackoverflow link:

https://stackoverflow.com/questions/37661119/python-mpl-toolkits-installation-issue

This PR is mostly concerned with providing support for jitter viewer in jupyter notebook, with much prettier 3D rendering. See comments on top of sasmodels/jitter.py for details on how to set it up. You will need to pip install ipyvolume in your jupyter environment before it will work.

@mdoucet
Copy link
Contributor

mdoucet commented Mar 12, 2019

OK since this is part of sasmodels I guess that's fine. But we should fix this in SasView. The menu item should not be displayed unless clicking it is going to work. Even when the window does pop up it's a little confusing because of the bottom part, which appears like controls that don't do anything.

@pkienzle
Copy link
Contributor Author

Works for me. Can you create the appropriate ticket describing the problem?

@butlerpd butlerpd merged commit edc783e into beta_approx Mar 19, 2019
@pkienzle pkienzle deleted the webgl_jitter_viewer branch March 19, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants