Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolution setting not persistent in theory mode of 5.0.1 #1460

Closed
butlerpd opened this issue Feb 16, 2020 · 4 comments
Closed

resolution setting not persistent in theory mode of 5.0.1 #1460

butlerpd opened this issue Feb 16, 2020 · 4 comments
Assignees
@butlerpd
Labels
Defect Bug or undesirable behaviour Inversion Perspective Concerns inversion perspective Major Big change in the code or important change in behaviour
Milestone
SasView 5.0.2

Comments

@butlerpd
Copy link
Member

start SasView. choose sphere and sphere in fit panel. Compute and show plot. the plot shows a bunch of oscillations as it should.

Now go to the resolution tab which shows None in the dropdown. Choose custom pinhole. enter 5 in the new box that pops up (i.e. 5% dq/q .. can be anything .. I also used 8 and 10). the plot updates smearing out the ocillations. hit compute and the plot flashes but again shows the oscillations being damped. However .... the second box showing the amount of smearing is gone and the dropdown again shows "None" hitting compute again will revert to an unsmeared curve. This is extremely annoying when playing around with parameters of a model after setting the resolution.
@butlerpd butlerpd added Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour SasView Bug Fixing labels Feb 16, 2020
@butlerpd butlerpd added this to the SasView 5.0.2 milestone Feb 16, 2020
@rozyczko rozyczko self-assigned this Feb 24, 2020
rozyczko added a commit that referenced this issue Feb 24, 2020
@rozyczko
Added persistency for the smearing choice between Compute actions. #1460
5d8a712
@rozyczko
Copy link
Member

Fixed in ESS_GUI_1460

@butlerpd butlerpd added the Inversion Perspective Concerns inversion perspective label Mar 17, 2020
@rozyczko
Copy link
Member

This has actually been already merged with ESS_GUI a while back.
Please review

@rozyczko rozyczko assigned butlerpd and unassigned rozyczko Mar 19, 2020
@butlerpd
Copy link
Member Author

will look at shortly

@butlerpd
Copy link
Member Author

since it is already merged there is no code review to be done but testing of the latest build of ESS_GUI (build 357 of March 19) shows it is now behaving properly so will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@butlerpd butlerpd

Labels
Defect Bug or undesirable behaviour Inversion Perspective Concerns inversion perspective Major Big change in the code or important change in behaviour
Projects
None yet
Milestone
SasView 5.0.2
Development

No branches or pull requests
2 participants
@rozyczko @butlerpd