Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0 no constraint for polydispersity ? #1588

Closed
RichardHeenan opened this issue Jun 12, 2020 · 3 comments · Fixed by #2348
Closed

5.0 no constraint for polydispersity ? #1588

RichardHeenan opened this issue Jun 12, 2020 · 3 comments · Fixed by #2348
Assignees
@rozyczko @lucas-wilkins @gonzalezma @m2cci-NMZ
Labels
Critical High priority For Feature Parity Issues to give 5x the same functionality as 4x
Milestone
SasView 6.0.0

Comments

@RichardHeenan
Copy link
Contributor

RichardHeenan commented Jun 12, 2020 •
edited
Loading

In my local build of ESS_GUI today, the attached project (rename .txt to .json) has polydispersities fitting, but they do not appear in the constraints set up drop down lists.

I thought that they might have been added now ? But may be this is still a work in progress?

12June2020_3sets_test2.txt

PS the parameter values in these fits are rather unphysical.
@RichardHeenan RichardHeenan added the Enhancement Feature requests and/or general improvements label Jun 12, 2020
@RichardHeenan RichardHeenan added this to the SasView 5.0.3 milestone Jun 12, 2020
@RichardHeenan RichardHeenan mentioned this issue Jun 12, 2020
Closed
@rozyczko
Copy link
Member

This is still in work as part of your more general "umbrella" ticket #1376

@rozyczko
Copy link
Member

the work is ongoing, and the corresponding branch is ESS_GUI_constrain_poly

@RichardHeenan
Copy link
Contributor Author

RichardHeenan commented Jun 12, 2020 •
edited
Loading

Aah, thank you, the branch took some finding, as its not been looked at for a long while, and I had closed the associated issue!

#1373

@RichardHeenan RichardHeenan mentioned this issue Jun 12, 2020
Closed
@rozyczko rozyczko modified the milestones: SasView 5.0.3, SasView 5.0.4 Jun 18, 2020
@rozyczko rozyczko added the Critical High priority label Jun 18, 2020
@rozyczko rozyczko self-assigned this Jun 18, 2020
@RichardHeenan RichardHeenan added For Feature Parity Issues to give 5x the same functionality as 4x and removed Enhancement Feature requests and/or general improvements labels Feb 16, 2021
@butlerpd butlerpd modified the milestones: SasView 5.0.4, SasView 5.1.0 May 2, 2021
@lucas-wilkins lucas-wilkins self-assigned this Jun 16, 2022
@gonzalezma gonzalezma mentioned this issue Oct 31, 2022
Merged
7 tasks
wpotrzebowski pushed a commit that referenced this issue Nov 23, 2022
Merge pull request #2348 from SasView/ESS_GUI_constrain_poly
dbdabd8 
Handling of constraints for polydisperse parameters (fix #1588)
@adrianrrennie adrianrrennie mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozyczko rozyczko

@lucas-wilkins lucas-wilkins

@gonzalezma gonzalezma

@m2cci-NMZ m2cci-NMZ

Labels
Critical High priority For Feature Parity Issues to give 5x the same functionality as 4x
Projects
None yet
Milestone
SasView 6.0.0
Development

Successfully merging a pull request may close this issue.

Handling of constraints for polydisperse parameters (fix #1588) SasView/sasview
6 participants
@RichardHeenan @rozyczko @lucas-wilkins @butlerpd @gonzalezma @m2cci-NMZ