Set SAS_DLL_PATH on sasview startup #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5.0 ready for testing on OSX |
|
5.0 ready for testing on Win |
rozyczko
approved these changes
May 31, 2020
| from sas import get_custom_config | ||
| # initialize sasmodels settings | ||
| from sas import get_custom_config, get_user_dir | ||
| if "SAS_DLL_PATH" not in os.environ: |
There was a problem hiding this comment.
Would it make sense to add SAS_DLL_PATH to the custom config file, like SAS_OPENCL does below?
There was a problem hiding this comment.
It's not really an option that the user needs to change, and there is no support for changing it in the gui, so no need to have it in the user config file.
It's in sasmodels kerneldll.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1560: SAS_DLL_PATH set on sasview startup if not already set in the environment