2060 read oommf v2 files #2116
Merged
2060 read oommf v2 files #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge it if all tests pass (it was review in #2061) |
wpotrzebowski
added
the
Discuss At The Call
|
I was about to merge it but I couldn't file test files from installer (on Mac). Are they supoosed to be shipped with installers? |
|
Currently the files are for unit tests only. It may be in the future added to folder avaialable to users |
butlerpd
removed
the
Discuss At The Call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to this PR as it was merged with release_5.0.5 before