Include sas.qtgui.Utilities.Reports in build output #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py and fix related package issue
lucas-wilkins
approved these changes
Aug 11, 2022
…lude missing dependencies to workflows
There was a problem hiding this comment.
@krzywon do we need to add all this dependencies to docs.yml and test.yml? I think initial idea was to have these jobs light-weight. I understand that for consistency it may be worth to keep the same set of requiremenets for all ymls.
butlerpd
added
the
Discuss At The Call
butlerpd
removed
the
Discuss At The Call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some testing, I found a couple of things missed by PR #2065. The Reports package was never included in setup.py so builds would likely not include the reports dialog (untested). Also, a unit test package was named incorrectly.