Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: Fixed breaking bug in pr_inversion #2178

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

lucas-wilkins
Copy link
Contributor

@lucas-wilkins lucas-wilkins commented Sep 2, 2022

Fix for #2176 - can the first person to check it please merge it too!

@lucas-wilkins lucas-wilkins added Defect Bug or undesirable behaviour Critical High priority Blocker Prevents a different issue from being resolved labels Sep 2, 2022
@lucas-wilkins lucas-wilkins marked this pull request as ready for review September 2, 2022 18:18
@krzywon krzywon merged commit ff41e1d into main Sep 2, 2022
anthonyroussel added a commit to anthonyroussel/nixpkgs that referenced this pull request Sep 18, 2022
Caused by `asscalar` numpy API removal.
See SasView/sasview#2178
@krzywon krzywon deleted the 2176-pr-inversion-is-broken-and-breaks-tests branch September 20, 2022 18:23
@krzywon krzywon restored the 2176-pr-inversion-is-broken-and-breaks-tests branch November 30, 2022 14:25
@krzywon krzywon deleted the 2176-pr-inversion-is-broken-and-breaks-tests branch December 9, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Prevents a different issue from being resolved Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pr inversion is broken, breaks tests, and any published version that does not package numpy
2 participants