Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop debugpy from installer #2259

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

llimeht
Copy link
Contributor

@llimeht llimeht commented Oct 25, 2022

debugpy isn't used anywhere in the sasview code or in the documentation/examples; bundling it into the installer requires additional fragile workarounds, so if it's not needed, can we drop it?

debugpy isn't used anywhere in the sasview code or in the examples
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac installer and it worls fine

@wpotrzebowski wpotrzebowski merged commit 2248819 into SasView:main Oct 25, 2022
@llimeht llimeht deleted the tmp/drop-debugpy branch October 26, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants