-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few more or less obvious fixes for speed of SasView startup #2275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says it does. I measured the time to open the main window and it decreased from 21.5 seconds running the main branch to 11.1 seconds for this one.
More modest gain in my Windows machine (from ~30" to ~18"), but still an improvement. |
Maybe src/sas/sascalc/pr/p_invertor.py as well? |
In the startup profiling (Win10, dev build), importing the inversion perspective takes less than 1%. I'll add it anyway. Other external imports, e.g. |
importing bumps options can't be made lazy, since we need to display the default bumps minimizer name, meaning importing and querying the module at start time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the code seem harmless and it works fine on Mac
From >30 sec down to ~5 sec.
numba related fixes suggested by @pkienzle + minor other import shuffling as suggested by startup profiles.