Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix confusing slit resolution parameters and add guardrails #2283

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

pbeaucage
Copy link
Contributor

@pbeaucage pbeaucage commented Oct 26, 2022

As discussed at length in #1753, this adds several guardrails to prevent incorrect use of the 1D slit-smearing function. Specifically, adds LOUD warnings if a user specifies a slit length that is less than the width, a slit geometry with an aspect ratio less than 10:1, or a slit length less than q_max for the data.

This also changes the nomenclature throughout from the confusing qx_width and qy_width to the canSAS standard q_length and q_width, where length is the long axis of the slit and width the short axis.

This depends on and is linked to issue SasView/sasmodels#528 and PR SasView/sasmodels#530

Copy link
Contributor

@lucas-wilkins lucas-wilkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The severity of the log message (critical) is not really conveyed by the look of the popup. It there not a standard "dire" popup in QT? at least something with a red box with an x in it? Also I'm wondering if the request in the issue that the length be larger than the qmax is not a bit aggressive? Finally, I think that length is actually the half length of the slit? Even so, USANS would not actually qualify (and doubt USAXS would either?

I suggest we remove the requirement for length to be larger than qmax and merge this as better than before and then look more deeply into whether we should be limiting the qmax to smaller than length? Also some more indication of the importance of the pop up would be good.

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works from development environment and cannot really test installer since it depends on the sasmodels as well so merging now. We may want to look again at the popup later.

@butlerpd butlerpd merged commit 1b00660 into main Oct 27, 2022
@pkienzle pkienzle deleted the 1753-fix-confusing-slit-resolution branch November 4, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants