Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2319: Fix copy/paste when selecting a structure factor #2320

Merged
merged 1 commit into from
Oct 28, 2022
Merged

2319: Fix copy/paste when selecting a structure factor #2320

merged 1 commit into from
Oct 28, 2022

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Oct 28, 2022

Use the new perspective class methods that replaced the old copy/paste methods.

Fixes #2319

rozyczko
rozyczko approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I forgot to assign myself to this issue and fixed it as well.
Exactly the same, so it seems yours must also be correct :)

@wpotrzebowski wpotrzebowski self-requested a review October 28, 2022 18:22
wpotrzebowski
wpotrzebowski approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac. Works fine.

@wpotrzebowski wpotrzebowski merged commit 372e378 into main Oct 28, 2022
@wpotrzebowski wpotrzebowski deleted the 2319-copy-paste-structure-factor branch October 28, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpotrzebowski wpotrzebowski wpotrzebowski approved these changes

@rozyczko rozyczko rozyczko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting structure factor from Fit Panel leads to backtrace
3 participants
@krzywon @wpotrzebowski @rozyczko