Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up some tests that were broken during codecamp #2326

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Fix up some tests that were broken during codecamp #2326

merged 2 commits into from
Oct 29, 2022

Conversation

llimeht
Copy link
Contributor

@llimeht llimeht commented Oct 29, 2022

Some tests were broken during recent merges. This does some cleanup.

@llimeht llimeht mentioned this pull request Oct 29, 2022
Merged
rozyczko
rozyczko approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Works as expected.

@wpotrzebowski wpotrzebowski self-requested a review October 29, 2022 16:05
wpotrzebowski
wpotrzebowski approved these changes Oct 29, 2022
View reviewed changes
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on OSX. Works fine

@wpotrzebowski wpotrzebowski merged commit 87b9572 into SasView:main Oct 29, 2022
@llimeht llimeht deleted the tmp/fix-tests-hidablequit branch October 30, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozyczko rozyczko rozyczko approved these changes

@wpotrzebowski wpotrzebowski wpotrzebowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llimeht @wpotrzebowski @rozyczko