Add +/- 1 and 3 sigma lines on residual plots #2443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Residual plots should now have 2 red lines at +/- 3 sigma and 2 dashed gray lines at +/-1 sigma. There does not seem to be any documentation that needs updating.
The only change necessary for this was to use the
data1D_plot_role
already established. This allows the fix to require only a small 5 line block of code in thePlotterWidget
inplotter.py
. Basically ifdata.plot_role==data1D.ROLE_RESIDUAL
then add 4 horizontal lines (ax.axhline()
).Fixes #1329
How Has This Been Tested?
by running in developer environment
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Load a data set (AOT microemulsion for example), send to fitting, choose a model (e.g. sphere/core_shell_sphere), hit compute/plot and/or fit (after choosing some parameters to fit). The residual plots should have the extra 4 lines.
Review Checklist (please remove items if they don't apply):