Largest, not first maximum used in corfunc #2457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/SasView/sasview into 2444-parameter-extraction-lines-on-corfunc
lucas-wilkins
added
the
Corfunc Perspective
|
@smk78 Change made, but I didn't have the wobbles you did for your input file. |
lucas-wilkins
added
Discuss At The Call
|
Needs looking at. |
butlerpd
removed
the
Discuss At The Call
|
Is this change in #2463 or do I have to review this and that? |
krzywon
approved these changes
Mar 16, 2023
| def supplementary(self, supplementary_data: SupplementaryParameters): | ||
| self._supplementary = supplementary_data | ||
|
|
||
| self.draw_data() # Is this needed? |
There was a problem hiding this comment.
Is it needed? I only ask because you are asking yourself here.
|
|
||
| The 1d correlation function in self.data, the 3d correlation function | ||
| in self.data3, and the interface distribution function in self.data_idf | ||
| are all draw in on the plot in linear cooredinates.""" |
There was a problem hiding this comment.
Yes, but not mine
lucas-wilkins
deleted the
2453-corfunc-parameter-extraction-is-not-correctly-identifying-the-long-period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says (based on #2450)
Review Checklist (please remove items if they don't apply):