2482 problem with dragging slicer elements on plot #2515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the error due to the confusion between base and base.base which had all interactors redraw the plot first and updating from the move second. This was resolved in the "moveend" method but made using the mouse to set the interactor rather difficult to do precisely. This was also cleanded up in the three interactor/slicer modules not currently used but that probably will be for the needs of the magnetic/crystal scattering communities. Duplicate draws were removed when appropriate.
First pass at fixing the slicer classes docstrings.
There are three unused slicer modules that are set up for wedge type slicers. These were never implemented. I suspect that in fact it was orinally planed to use this for sector averaging where perhaps the wedge became a sector by making r1=0 and r2 = qmax. However as it stands it left two slicers classes called SectorInteractor. This unused class is renamed to the more appropriate WedgeInteractor in preparation for being used for crystal type data.
wpotrzebowski
added
the
Discuss At The Call
krzywon
requested changes
May 8, 2023
|
@butlerpd to look at it. |
wpotrzebowski
removed
the
Discuss At The Call
wpotrzebowski
added
the
Discuss At The Call
|
@butlerpd to look at it |
wpotrzebowski
removed
the
Discuss At The Call
wpotrzebowski
added
the
Discuss At The Call
|
@butlerpd will fix at least one issue |
wpotrzebowski
removed
the
Discuss At The Call
…'left' and 'right' are set correctly when calling SideInteractor.update().
rozyczko
approved these changes
Jul 14, 2023
| # Check if the left side has moved and update the slicer accordingly | ||
| if self.left_line.has_move: | ||
| self.main_line.update() | ||
| self.left_line.update(phi=None, delta=None, mline=self.main_line, | ||
| side=True, left=True) | ||
| self.right_line.update(phi=self.left_line.phi, delta=None, | ||
| mline=self.main_line, side=True, | ||
| left=False, right=True) | ||
| mline=self.main_line, side=True, right=True) |
There was a problem hiding this comment.
Is this necessary? The default value of left is False so you probably don't need to explicitly set it
| # Check if the right side line has moved and update the slicer accordingly | ||
| if self.right_line.has_move: | ||
| self.main_line.update() | ||
| self.right_line.update(phi=None, delta=None, mline=self.main_line, | ||
| side=True, left=False, right=True) |
butlerpd
added
the
Discuss At The Call
…Also added back a superfluous self.update() call for consistency with the other slicers.
|
I would like to review this a bit more closely as the fix suggests some possible deeper problems in the code. Since we are now working heavily on this bit, it is worth checking this out I think. |
butlerpd
removed
the
Discuss At The Call
|
Everything in this PR is in #2566 - I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main thing this does is to Fix #2482 by making sure the plot is updated first and then drawn on drag operations for all slicere. In the process 2 other commits were made to
Fixes #2482
How Has This Been Tested?
the functional changes were tested by following the steps described in the issue this fixes and verifying that the behavior is now as expected.
Review Checklist (please remove items if they don't apply):