-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rog and beta q #2535
Rog and beta q #2535
Conversation
…ring BetaQ from Backend into UI and revise calculation method (sleep)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let myself comment a bit on the general style.
Functionality seems to be OK and the code looks good.
No real issues, just some pointers on how to make the code look more "pythonic"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adjusted the Generic Scattering Calculator to automatically calculate and display the Radius of Gyration (only for non-element nuclear data). Furthermore, added Beta Q calculations into the Generic Scattering Calculation. A new box has been added to the QComboBox, giving 3 options now- "Fixed Orientation" (2D), "Debye Full Avg." (1D) and "Full Avg. w/ Beta(Q)" (1D). Selecting Full Average w/ Beta Q will perform the same actions as Debye Full Average, but will also plot a second graph of "Q vs Beta(Q)" next to the "Q vs form factor" graph in the main window.
periodictable import has been added as well.
How Has This Been Tested?
NOTE: Have not tested against Magnetic Data or Element Data yet due to a lack of Magnetic or Element Data files. May need to test to ensure the program is not crashed by it. May have to disable Beta Q Calculations for Magnetic Data if that is the case.
Review Checklist (please remove items if they don't apply):