Updated rG&rg #2548
Closed
Updated rG&rg #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzywon
reviewed
Jul 14, 2023
butlerpd
added
the
Discuss At The Call
|
This pull request and #2538 should be reviewed and hopefully approved but should d to wait be merged into one big pull request to resolve all the UI conflict and that pull request then merged. To avoid confusion I'm labeling this as WIP |
butlerpd
removed
the
Discuss At The Call
butlerpd
added
the
Discuss At The Call
|
Once Jeff approves this we need to close the PR as the changes have been munged into PR #2565. This PR should NOT be merged |
|
These changes are mostly repeated in #2565. Review and merging will be easier if you combine them into one PR, or base one PR off the other. |
|
@krzywon can this branch now be safely deleted? I think this is the other PR that was merged into a bigger one before closing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon discussion with @butlerpd @pkienzle and @yunliu01, we decided it would be best to make the difference between Mass Based Radius of Gyration (Rg) and SLD Based Guinier Radius (RG) more obvious. I have separated the radius of gyration into two boxes, one for Mass-Based and one for SLD-Based.
I have also included code to change the SLD-Based RG based on the Solvent SLD, but that is commented out until a standard for determining protein volume can be agreed upon.
How Has This Been Tested?
Open Generic Scattering Calculator
Review Checklist (please remove items if they don't apply):