Two options to disable residuals and polydispersity distribution plots #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 19, 2023 10:15
Note that : 1) the residuals are still computed even if the option is checked 2) the issues 2526 2527 still remains
butlerpd
added
the
Discuss At The Call
|
@lucas-wilkins to review as it speaks to both plotting and preferences panel |
src/sas/system/config/config.py
Outdated
| @@ -197,6 +197,14 @@ def __init__(self): | |||
| # sets the maximum number of characters per Fitting plot legend entry. | |||
| self.FITTING_PLOT_LEGEND_MAX_LINE_LENGTH = 30 | |||
|
|
|||
| # Residuals management | |||
| # If true, disables residuals display | |||
| self.DISABLE_RESIDUALS = False | |||
There was a problem hiding this comment.
please make config entries as explicit as reasonably possible,
I suggest DISABLE_RESIDUAL_PLOT at least
There was a problem hiding this comment.
No problem, done.
added 3 commits
July 26, 2023 10:22
…config.py and 'disableResidualsPlot' the 'disableResiduals' widget in DisplayPreferencesWidget.py
lucas-wilkins
approved these changes
Aug 1, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two additional options in Display Settings.
The first one allows to disable residuals display, the second one allows to disable polydispersity distribution plot display.
How Has This Been Tested?
(De)activate one option in
Preferences > Display Settingsand try to plot the residuals / polydispersity distribution plot.Note
If the user activates the option for the residuals after plotting the residuals (for instance if he/she wants to disable the residuals before a fit), the residuals won't disappear (before or after a second plot). Issue #2526 still remains.
Review Checklist (please remove items if they don't apply):