Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's new dialog #2608

Merged
merged 12 commits into from
Sep 18, 2023
Merged

What's new dialog #2608

merged 12 commits into from
Sep 18, 2023

Conversation

lucas-wilkins
Copy link
Contributor

What's New: Tip of the Day style dialog.

Currently a draft as depends strongly on config, and on files that need to be packaged correctly. There are some placeholder files included that should not be released.

Definitely need to check installers for this one!

Expected behaviour is that it will show messages for V5.1.7 and 7.0 (and not for 5.0.6).

@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements Documentation Concerns documentation labels Sep 16, 2023
@lucas-wilkins lucas-wilkins linked an issue Sep 16, 2023 that may be closed by this pull request
@lucas-wilkins lucas-wilkins marked this pull request as ready for review September 18, 2023 09:42
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I will test functionality

src/sas/system/config/config.py Show resolved Hide resolved
@wpotrzebowski
Copy link
Contributor

I've tried to run it from the installer and it is failing with
13:33:14 - sas.qtgui.MainWindow.MainWindow - ERROR - Application failed with: No module named 'sas.qtgui.Utilities.WhatsNew.messages'
13:33:14 - sas.qtgui.Perspectives.Fitting.FittingWidget - ERROR - Traceback (most recent call last):

@rozyczko
Copy link
Member

rozyczko commented Sep 18, 2023

Please keep in mind that the additional (non-py) files need to be manually added as data to the pyinstaller script. This applies to the HTML files you created.

datas list in installers\sasview.spec should be modified.

@rozyczko
Copy link
Member

rozyczko commented Sep 18, 2023

Running from the dev build.

Default settings work fine.
When switched to "Don't show this window" and restarting SV, I get

15:11:52 - sas.qtgui.Perspectives.Fitting.FittingWidget - ERROR - Traceback (most recent call last):
  File "c:\projects\sasview\run.py", line 94, in <module>
    sys.exit(sas.cli.main(logging="development"))
  File "C:\projects\sasview\src\sas\cli.py", line 161, in main
    run_sasview()
  File "C:\projects\sasview\src\sas\qtgui\MainWindow\MainWindow.py", line 103, in run_sasview
    mainwindow = MainSasViewWindow()
  File "C:\projects\sasview\src\sas\qtgui\MainWindow\MainWindow.py", line 47, in __init__
    raise ex
  File "C:\projects\sasview\src\sas\qtgui\MainWindow\MainWindow.py", line 44, in __init__
    self.guiManager = GuiManager(self)
  File "C:\projects\sasview\src\sas\qtgui\MainWindow\GuiManager.py", line 116, in __init__
    self.addWidgets()
  File "C:\projects\sasview\src\sas\qtgui\MainWindow\GuiManager.py", line 206, in addWidgets
    self.WhatsNew = WhatsNew(self)
  File "C:\projects\sasview\src\sas\qtgui\Utilities\WhatsNew\WhatsNew.py", line 98, in __init__
    self.show_file()
  File "C:\projects\sasview\src\sas\qtgui\Utilities\WhatsNew\WhatsNew.py", line 108, in show_file
    filename = self.all_messages[self.current_index]
IndexError: list index out of range

@wpotrzebowski wpotrzebowski merged commit 26ce41c into main Sep 18, 2023
@wpotrzebowski wpotrzebowski deleted the 2569-whats-new-dialog branch September 18, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Concerns documentation Enhancement Feature requests and/or general improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"What's New" dialog
3 participants