Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sas_gen.py #2617

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update sas_gen.py #2617

merged 2 commits into from
Sep 20, 2023

Conversation

timsnow
Copy link
Contributor

@timsnow timsnow commented Sep 18, 2023

Adding dictionary lookup for speed increases

@timsnow
Update sas_gen.py
db16caa 
Adding dictionary lookup for speed increases
@wpotrzebowski
Copy link
Contributor

I've tested this PR on https://github.com/Andre-lab/hbv_trSAXS/blob/master/HBVCP_empty_assembly/bayesian_models/capsid_T4.pdb and it produced
21:29:00 - WARNING: Warning: set the sld of C to zero
for each entry. (thus the loading was slow)

@timsnow
Correction for Na to NA
6029972 
Small typo lead to continual exceptions being raised
@timsnow
Copy link
Contributor Author

timsnow commented Sep 19, 2023

Caught that, have amended a typo.

wpotrzebowski
wpotrzebowski approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the latest fix loading works fine

@krzywon krzywon merged commit 22fe701 into main Sep 20, 2023
44 checks passed
@krzywon krzywon deleted the Sasgen-Fix branch September 20, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpotrzebowski wpotrzebowski wpotrzebowski approved these changes

@butlerpd butlerpd Awaiting requested review from butlerpd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timsnow @wpotrzebowski @krzywon