Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build rules to not double fire on PRs #2686

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Change build rules to not double fire on PRs #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
name: CI

on:
[push, pull_request, workflow_call]
workflow_call:
pull_request:
push:
branches: [main]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this trigger CI only for the pushes to 'main' branch only? Personally,I look at CI runs for any branch (without opening PR), however, this indeed may be a waste of resources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. If you add workflow_dispatch you can also press a button in "actions" to launch a build on any commit/branch/whatever.

tags: ['v*']

defaults:
run:
Expand Down