Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote file names in ConvertUI #2793

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Quote file names in ConvertUI #2793

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5af4f6
Quote file names in ConvertUI
MariannaGerina Jan 22, 2024
3f135e0
follow @llimeht recommendation (I think) to remove problems with spec…
butlerpd Feb 16, 2024
79f2594
added check=true to capture errors as per @llimeht suggestion.
butlerpd Feb 20, 2024
f3f2f24
Merge branch 'release_6.0.0' into 2791-convertUI-fix
butlerpd Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sas/qtgui/convertUI.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ def pyrrc(in_file, out_file):
"""
Run the qt resource compiler
"""
run_line = f"pyside6-rcc {in_file} -o {out_file}"
os.system(run_line)
run_line = ["pyside6-rcc", in_file, "-o" ,out_file]
subprocess.run(run_line, check=True)


def pyuic(in_file, out_file):
Expand All @@ -34,8 +34,8 @@ def pyuic(in_file, out_file):
"""
in_file2 = os.path.abspath(in_file)
out_file2 = os.path.abspath(out_file)
run_line = "pyside6-uic " + in_file2 + " -o " + out_file2
os.system(run_line)
run_line = ["pyside6-uic", in_file2 "-o", out_file2]
subprocess.run(run_line, check=True)

def file_in_newer(file_in, file_out):
"""
Expand Down
Loading