Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem with using deprecated node.js #2836

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

butlerpd
Copy link
Member

@butlerpd butlerpd commented Mar 26, 2024

Description

Our builds are throwing a number of warnings every time a CI runs due to the deprecated version of the node.js module being used by the older versions of actions/setup-python and actions/checkout. The latest version are using the upgraded node.js

Note: that line 38 of nightly-build.yml was using actions/setup-python@v1 instead of v4. It was also incremented to v5 but we should pay attention here - though it will likely have no affect until merged to main?

Fixes #2810

How Has This Been Tested?

TBA (needs to build)

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Builds are throwing a ton of warnings every time the CI runs due to the deprecated module being used by the older versions of actions/setup-python and actions/checkout
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly build should only be called from main branch, so we probably will need to the same fixes to main

@krzywon
Copy link
Contributor

krzywon commented Apr 11, 2024

There are still node.js warnings in this build related to actions/upload-artifact@v3 and actions/download-artifact@v3. These should probably be changed here.

@rozyczko
Copy link
Member

There are still node.js warnings in this build related to actions/upload-artifact@v3 and actions/download-artifact@v3. These should probably be changed here.

Both should be upgraded to v4

@wpotrzebowski
Copy link
Contributor

@butlerpd I forgot about this PR and started working #2860... Can we merge this one and then merge #2860?

@krzywon
Copy link
Contributor

krzywon commented Apr 24, 2024

#2860 fixes the other build warnings, so I'm merging this so the other PR isn't held up.

@krzywon krzywon merged commit 34b3a6c into release_6.0.0 Apr 24, 2024
36 checks passed
@krzywon krzywon deleted the 2810-ci-using-deprecated-actions branch April 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants