Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1726 allow user to choose default for plot navigation tools - merge into release_6.0.0 #2849

Conversation

juliuskarliczek
Copy link
Member

@juliuskarliczek juliuskarliczek commented Apr 10, 2024

Description

Same changes as mentioned in pull request #2845
Added documentation changes in preferences_help.rst as suggested in #2845

Added a checkbox in Preferences/Plotting Settings for using the matplotlib toolbar. Therefore edited the config and added USE_MATPLOTLIB_TOOLBAR.

Fixes # (issue/issues)
Fixes issue https://github.com/SasView/sasview/issues/1726 , where access to the standard matplotlib toolbar is requested.

How Has This Been Tested?

Local win10 build, tried plotting with and without the checked checkbox in the preferences. Both worked. Not sure, why the toolbar was disabled by default. Maybe that has to be checked.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@juliuskarliczek juliuskarliczek changed the title 1726 allow user to choose default for plot navigation tools: cherry-picking for release 6.0.0 1726 allow user to choose default for plot navigation tools - merge into release_6.0.0 Apr 10, 2024
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review complete. I plan to test both the Mac and Windows installers later today.

@juliuskarliczek juliuskarliczek merged commit d700cb6 into release_6.0.0 Apr 15, 2024
36 checks passed
@juliuskarliczek juliuskarliczek deleted the 1726-allow-user-to-choose-default-for-plot-navigation-tools_release_6.0.0 branch April 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants