Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1524 when loading data the data explorer should revert to the data tab #2852

Conversation

juliuskarliczek
Copy link
Member

Description

Added logic to DataExplorer.py, in which the current tab is changed upon calling loadFromURL() in DataExplorer.py

Fixes # (issue/issues)
Fixes issue #1524

How Has This Been Tested?

local win10 build, loaded data and tab changed

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rozyczko
Copy link
Member

rozyczko commented Apr 12, 2024

Just a note - there is a separate method for changing tabs in the DE: (line 176)

def changeTabs(self, tab=0):

which could have been used.
But it does not really matter since the functionality is very straightforward.

(Also, to be very nitpicky, the comment is not entirely right, since the switch does not happen after the reading, but during, since we're reading the files in a separate thread... )

@juliuskarliczek juliuskarliczek merged commit 232ff64 into release_6.0.0 Apr 15, 2024
36 checks passed
@juliuskarliczek juliuskarliczek deleted the 1524-when-loading-data-the-data-explorer-should-revert-to-the-data-tab branch April 15, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants