Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyopengl_accelerate from requirements.txt #2865

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

wpotrzebowski
Copy link
Contributor

@wpotrzebowski wpotrzebowski commented Apr 28, 2024

Description

Removing pyopengl_accelerate package from requirements.txt because it is not required and causing problems with setting up dev env on Mac.

Note: We will also need to merge it main.

How Has This Been Tested?

It has been tested locally by creating a new environment.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@butlerpd
Copy link
Member

Is there a reason this is a draft only?

Once merged it may be time for another merge of release_6.0.0 to main?

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in windows .. including the orientation viewer in openGL so I guess this should be ready to merge assuming the Mac installer still works?

@wpotrzebowski
Copy link
Contributor Author

It initially failed on python 3.11 test and thus I kept it as a draft but now it seems to work fine. Movie to "ready for review"

@wpotrzebowski wpotrzebowski marked this pull request as ready for review April 29, 2024 08:02
@butlerpd butlerpd added the SasView 6.0.0 Required for 6.0.0 release label Apr 29, 2024
@butlerpd butlerpd merged commit 731ea4b into release_6.0.0 Apr 30, 2024
29 checks passed
@butlerpd butlerpd deleted the pyopengl_accelerate_removal branch April 30, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants