2732 fill in whats new boxes for release 6.0.0 #2880
Conversation
lucas-wilkins
added
the
Discuss At The Call
|
Comparing the beta release notes to the current contents of the
|
|
I was planning on neatening things up tomorrow. I think the font size is to small, at least it seems so on my machine. @krzywon - I think the images need a bit of reworking - I was planning on that tomorrow. Two things, if you let the renderer rescale the images it does a very bad job, and I want some nice fading out it doesn't look blocky. I'll sort it though, just letting you know my plans. Do let me know if you plan to change the images again though, and I'll wait. |
|
@lucas-wilkins - The latest images are better than the ones I replaced. Feel free to modify/replace/update them as you see fit. I'll wait for you to make your modifications before I push anything else to this branch. |
|
@krzywon OK, done with it for now. |
Section seems ok to me, do you think it should be more detailed? |
Personally, I think its about right ... but I did write it. Going for short, simple English, with as few technical details as possible. There are docs for details. |
|
I just added the full changelist to the last page. I took it from the draft 6.0.0b1 release page. I think the changes made by @lucas-wilkins look good in their simplicity. In future iterations, we might want to link to the documentation. Unless we want more pages, I think this is ready for review. |
There was a problem hiding this comment.
Tried the last actions build for this branch on W10/x64 (https://github.com/SasView/sasview/actions/runs/9407271049). It installed and opened but threw an exception (see comment) from the What's New box.
|
|
Need to add that to the installer path, or an |
|
check installer then merge |
There was a problem hiding this comment.
So I just tried this build, https://github.com/SasView/sasview/actions/runs/9600919075, and it's still failing with the same error from the What's New when I start SasView.
butlerpd
removed
the
Discuss At The Call
There was a problem hiding this comment.
I just tested the installed version on Windows after the latest change by @lucas-wilkins and the What's New box now opens as expected. I think this is ready to go.
@smk78 - you were the one to see the original issue. If it's now working as expected for you, please feel free to merge.
The What's New box is now looking pretty reasonable, and I've made improvements to its logic and appearance so it feels much nicer now.
Access it from
What's NewinHelpif it doesn't automatically pop up.I have not filled in anything for the plotting section or the GSC, perhaps @krzywon / @rozyczko, and @yunliu01 / @klytje would like to fill it in. Literally just need one two simple sentences and, preferably, at least one image. I can clean things up.
The last slide is for the changelist, which will be added during the final release prep.
Testing needed: As the resources backing the dialog will get packaged, we should check that it runs from the installers (should find out pretty quickly).