Update model editor #2918
Draft
Update model editor #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Function text box is hidden
…l file to generate
The code changes in `PluginDefinition.py` add two new checkboxes for generating Python and C code in the UI. These checkboxes allow the user to specify whether they want to generate Python or C code when working with the plugin.
…el and saves as a .c file
…nguages to generate
…ing C model template, connect so that it writes template to .c file and formats with user-input parameters
…re specified by separating pd-dependent funcs into C_PD_TEMPLATE and only including it if pd params exist
…on and C models, linking them.
…q flag into python template by default
…lugin editor changes bug fix: ensure that both a syntax check and a model check is run on model file before approving it; condense into checkModel method
…o checkModel in previous commit
…with C code. Clear highlights from both python and C windows if checks pass. Ensure that checkModel() is always passed a path argument instead of raw text.
… by removing os.remove(). allow user to load .c models into editor even if .c file fails model checks
… self.filename_py works fine.
… bad model check via QMessageBox prompt. This ensures no bad models are written to files without user agreement. Define full_path outside of python-specific code so that we can access it in C-specific code
… C model because no model checks can be run without a python wrapper. add showNoCompileWarning so user can override dialog after first showing
…esn't wrap in QTableWidget headers
…Tab(). Initialize c_editor_widget in addWidgets(), only add editor widgets if needed, do not add widgets if one of same type already exists.
tsole0
added
Enhancement
…Modified signal was not connected
… user plugins directory, display helper text and disable checkbox.
… editing finished
… to find function text, load model using importlib.util to find access variables.
tsole0
removed
the
Discuss At The Call
|
This should be superseded by #3135. Keeping it open for now, but likely will be closed next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PluginEditor.py(dd7819a, 98c0a31, 6dc2f84)source = ['filename.c']into Python model template if both Python and C are generated (27ac6d6)sasmodels) (0c61d51, a1d04b3)Note: Merged #2917 into branch to fix tests
Note: Shares two commits with model-editor-bug-fixes branch (ba4cbc7, 26e6b59) because ba4cbc7 originated on this branch and 26e6b59 was necessary for error-checking C models
Linting:
de25165, 3ea3929
How Has This Been Tested?
TODO: windows installer, mac installer
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
TODO: Need minor documentation changes!!
Installers
Licencing (untick if necessary)