New version of splash screen and icon

[wpotrzebowski]

Description

A new version of the splash screen as discussed in #2878. I will also try to update icon in the same PR

Fixes # (issue/issues)

How Has This Been Tested?

Start sasview and how the splash screen and icon looks like

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

• There is nothing that needs documenting
• Documentation changes are in this PR
• There is an issue open for the documentation (link?)

Installers

• There is a chance this will affect the installers, if so
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

• The introduced changes comply with SasView license (BSD 3-Clause)

[lucas-wilkins]

closes #2907

[wpotrzebowski]

I can see the splash screen when I run locally but not from the installer... This happens on Mac. Can someone else check if this is a reproducible behavior?

[smk78]

After download on Windows:

[smk78]

On launch on Windows:

[smk78]

But I still have the old ball icon in the toolbar:

[smk78]

Welcome:

[smk78]

Interestingly, the icons in the installation folder are also the old ones:

But if I right click on the sasview app and do Properties it shows the new one!

[smk78]

From what I'm reading there is no way to change the icon on an executable once it's installed (only the icon on a shortcut to an executable). So the old icon must be being associated with the sasview application somewhere in the installer build...

[lucas-wilkins]

I think the icon is specified in the .spec file, so it needs updating there, it might link to a different copy of the images (we have too many copies of the same images still)

[lucas-wilkins]

Problem reproduced on my mac and I've identified the cause!

[lucas-wilkins]

@wpotrzebowski Should be fixed!

[wpotrzebowski]

@lucas-wilkins Thanks for looking at it.
The installer seems to be crashing with

[96363] Failed to execute script 'sasview' due to unhandled exception: No module named 'sas.qtgui.images'
[96363] Traceback:
Traceback (most recent call last):
  File "sasview.py", line 15, in <module>
  File "sas/cli.py", line 161, in main
  File "sas/qtgui/MainWindow/MainWindow.py", line 92, in run_sasview
  File "sas/qtgui/MainWindow/MainWindow.py", line 63, in SplashScreen
  File "importlib/resources/_legacy.py", line 25, in wrapper
  File "importlib/resources/_legacy.py", line 46, in open_binary
  File "importlib/resources/_common.py", line 22, in files
  File "importlib/resources/_common.py", line 53, in get_package
  File "importlib/resources/_common.py", line 44, in resolve
  File "importlib/__init__.py", line 126, in import_module
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'sas.qtgui.images'

[lucas-wilkins]

@wpotrzebowski it might be because the installer has given it a different name (e.g. just images). I could change the path to images, but then the local dev will break. I'll see if I can add both paths "images" and "sas.qtgui.images" to the installer and have them point to the same place.

[wpotrzebowski]

Thanks @lucas-wilkins. It works now

[wpotrzebowski]

Interestingly, the icons in the installation folder are also the old ones:

But if I right click on the sasview app and do Properties it shows the new one!

I've checked that spec file refers to updated icon files.

[wpotrzebowski]

I've replaced all possible icon files. Indeed, there are plenty. @smk78 can you please check if you still can see old ball in the installation folder?

[smk78]

@wpotrzebowski I tried https://github.com/SasView/sasview/actions/runs/9789639783 on W10/x86.

The new logo appears on the installer file, and on the installation dialog box, but not :

• on the shortcut that is created (if you check that option in the installation dialog)
• in the taskbar when the application starts!
• or on the sasview & unins00 applications in the installation folder

[lucas-wilkins]

Looks good