Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1783: Reset transforms for new plots #3022

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Aug 15, 2024

Description

This resets the data transforms held by the Data objects on the creation of new plots.

Fixes #1783
Refs #3021

How Has This Been Tested?

Running from source, I tested plotting, changing scale, zoom, etc. I then replotted the same data in multiple ways (fit, new plot) and the new plots display in their default state.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR (inline)
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

…new plots from getting the transforms of previous plots
@krzywon krzywon added the SasView 6.0.0 Required for 6.0.0 release label Aug 16, 2024
@krzywon krzywon linked an issue Aug 20, 2024 that may be closed by this pull request
@butlerpd butlerpd self-requested a review August 21, 2024 14:25
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems reasonable as an interim, waiting for the transform to be owned by the plot and eventually for the full plot refactoring.

Testing shows that all the concerns raised in #1783 have indeed been addressed by this change. I do note a very strange auto range setting in that the home button autoranges only on the fit line from the linear fit (so usually a much smaller window than the full window) but that is clearly independent of anything done by this PR.

@butlerpd butlerpd merged commit cc61cc8 into release_6.0.0 Aug 21, 2024
28 checks passed
@butlerpd butlerpd deleted the 1783-new-plot-reset-transform branch August 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph scale carries over to other pespectives
2 participants